Skip site navigation (1) Skip section navigation (2)

posix_fadvise versus old kernels

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: posix_fadvise versus old kernels
Date: 2006-06-27 18:22:32
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
I've been digging into why buildfarm member thrush has been dumping core
consistently during the regression tests since the posix_fadvise patch
went in.  I've confirmed that posix_fadvise() itself will SIGSEGV in a
standalone test program, and found that this happens only if
_FILE_OFFSET_BITS=64 ... which is our default configuration on Linux.

Some googling turned up the following
which basically says that posix_fadvise64 + 2.4 kernel + older glibc
= crash.  It sounds like the 2.4 kernel hasn't got this call but glibc
thought it did, up till about a year ago.

While we could possibly come up with a suitable configure test to
determine whether posix_fadvise is actually safe to use on a given
system, I think we should seriously consider just reverting the patch.
As far as I saw, zero evidence was given that it actually does anything
measurable.  Without a benchmark to prove that it's worth spending more
time on, I'm disinclined to trouble over it.

			regards, tom lane


pgsql-hackers by date

Next:From: Greg StarkDate: 2006-06-27 18:28:43
Subject: Re: vacuum, performance, and MVCC
Previous:From: Magnus HaganderDate: 2006-06-27 17:49:46
Subject: Re: SO_SNDBUF size is small on win32?

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group