Re: BUG #5394: invalid declspec for PG_MODULE_MAGIC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Vladimir Barzionov <snego(dot)barsik(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #5394: invalid declspec for PG_MODULE_MAGIC
Date: 2010-04-06 19:55:01
Message-ID: 26200.1270583701@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki
> <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>> A patch attached. The name of "PGMODULEEXPORT" might be arguable.

> I agree with this in principle, but won't this break every single
> add-on module out there that supports Win32?

The patch didn't touch the contrib modules, so why would it break
third-party sources?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Erik Rijkers 2010-04-06 20:00:41 Re: Re: regexp_matches illegally restricts rows -- just a documentation issue?
Previous Message Josh Berkus 2010-04-06 19:42:12 Re: Re: regexp_matches illegally restricts rows -- just a documentation issue?

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-04-06 19:55:03 Re: SELECT constant; takes 15x longer on 9.0?
Previous Message David E. Wheeler 2010-04-06 19:53:33 Re: SELECT constant; takes 15x longer on 9.0?