| From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
|---|---|
| To: | "Arne Roland" <arne(dot)roland(at)malkut(dot)net>, "Tomas Vondra" <tomas(at)vondra(dot)me>, "Laurenz Albe" <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | "Anders Granlund" <anders(dot)granlund(dot)0(at)gmail(dot)com>, "Andreas Karlsson" <andreas(at)proxel(dot)se>, "Vik Fearing" <vik(at)chouppes(dot)com> |
| Subject: | Re: Key joins |
| Date: | 2026-07-11 21:52:13 |
| Message-ID: | 2606a427-466c-4d64-83f9-21f59ad5f4c6@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 8, 2026, at 02:19, Arne Roland wrote:
> Hi,
>
> the attached patch set is my attempt to break it up in a granular way.
> I will think about this further, but attached is my current patch,
> since it seems much easier to read.
>
> The difference to before is that the base commit is further broken up
> into a series of it's own:
>
> 1. Only prove FOR KEY joins between two base tables
> 2. Mechanics for advanced error messages
> 3. Derived tables
> 4. GROUP BY and DISTINCT
> 5. FILTER (WHERE ...)
> 6. Tracking of referenced and referencing filter clauses
> The later commits have only minor comment adjustments. The series
> should be easier to read now, since the individual steps with very
> different concerns are added one at a time. Please let me know, what
> you think.
Nice. I've looked at all ten patches, and I like how you've broken it
up.
I note that src/backend/parser/parse_key_join.c is now "just" 1487 loc
in 0001.
/Joel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-07-11 22:04:34 | Re: Tepid: selective index updates for heap relations |
| Previous Message | Hüseyin Demir | 2026-07-11 20:22:10 | Re: Checkpoint replication slots later |