Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, vignesh21(at)gmail(dot)com, lena(dot)ribackina(at)yandex(dot)ru, dam(dot)bel07(at)gmail(dot)com, zhihuifan1213(at)163(dot)com, daniel(at)yesql(dot)se, pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de, anisimow(dot)d(at)gmail(dot)com, HukuToc(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, a(dot)lepikhov(at)postgrespro(dot)ru
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
Date: 2024-01-19 14:26:25
Message-ID: 2585eaededf53b2d3d5663b9b1030584@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-01-19 22:27, Alexander Korotkov wrote:
> Hi!
>
> On Fri, Jan 19, 2024 at 2:37 PM torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
> wrote:
>> Thanks for making the patch!
>
> The patch is pushed! The proposed changes are incorporated excluding
> this.
>
>> > - /* If SAVE_ERROR_TO is specified, skip rows
>> > with soft errors */
>> > + /* If ON_ERROR is specified with IGNORE, skip
>> > rows with soft errors */
>>
>> This is correct now, but considering future works which add other
>> options like "file 'copy.log'" and
>> "table 'copy_log'", it may be better not to limit the case to
>> 'IGNORE'.
>> How about something like this?
>>
>> If ON_ERROR is specified and the value is not STOP, skip rows with
>> soft errors
>
> I think when we have more options, then we wouldn't just skip rows
> with soft errors but rather save them. So, I left this comment as is
> for now.

Agreed.
Thanks for the notification!

>
> ------
> Regards,
> Alexander Korotkov

--
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2024-01-19 14:28:00 Re: Assertion failure with epoch when replaying standby records for 2PC
Previous Message Daniel Gustafsson 2024-01-19 14:26:13 Re: pgsql: Clean up role created in new subscription test.