Re: [COMMITTERS] pgsql: Rename the members of CommandDest enum so

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Rename the members of CommandDest enum so
Date: 2005-11-03 17:55:37
Message-ID: 25785.1131040537@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Marc G. Fournier wrote:
>> Is this an appropriate commit for post-Beta? Does it fix a critical bug
>> that will prevent a release from happening? :(

> Well, I asked -hackers before committing, and there were no objections,
> plus there were a couple of messages that weren't actual encouragements
> but I took as sign of approval.

Yeah, I would have told him "no" if I thought there were any risk of
breaking things, but renaming some constants seems a pretty safe
activity --- the compiler will catch any overlooked cases.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2005-11-03 18:03:23 press - pr: Fix broken markup, a couple of typos and set the release
Previous Message Tom Lane 2005-11-03 17:45:30 pgsql: Thinking further, it seems we had better also copy down

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2005-11-03 18:02:13 Re: Reducing the overhead of NUMERIC data
Previous Message Tom Lane 2005-11-03 17:53:01 Re: Exclusive lock for database rename