| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Explicit shell types |
| Date: | 2006-02-28 22:38:43 |
| Message-ID: | 2563.1141166323@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> The only thing I considered wrong with the previous patch was it's odd
> behaviour w.r.t. creation of types with the same name as one in
> pg_catalog. However, Tom said this is not a serious issue given the
> same problem exists in many other places in PostgreSQL.
> So, I've added some regression tests and here is the patch for
> inclusion.
Applied with corrections --- most notably, you weren't setting the
dependencies correctly for a shell type, and referencing numeric
function OIDs from C code is not done.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-03-01 00:23:03 | Re: [HACKERS] pg_service.conf |
| Previous Message | Neil Conway | 2006-02-28 21:36:58 | Re: 2 line patch to allow plpythonu functions to return |