Re: [PATCH] XLogReadRecord returns pointer to currently read page

From: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] XLogReadRecord returns pointer to currently read page
Date: 2018-10-23 05:25:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 23.10.2018 0:53, Heikki Linnakangas wrote:
> I'd expect the decompression to read from the on-disk buffer, and unpack
> to readRecordBuf, I still don't see a need to copy the packed record to
> readRecordBuf. If there is a need for that, though, the patch that
> implements the packing or compression can add the memcpy() where it
> needs it.

I agree with it. Eventually, placement of the WAL-record can be defined
by comparison the record, readBuf and readRecordBuf pointers.
In attachment new version of the patch.

Andrey Lepikhov
Postgres Professional
The Russian Postgres Company

Attachment Content-Type Size
0001-WAL-record-buffer-pointer-fix.patch text/x-patch 2.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2018-10-23 05:33:29 RE: WAL archive (archive_mode = always) ?
Previous Message Nagaura, Ryohei 2018-10-23 04:37:23 Timeout parameters