Skip site navigation (1) Skip section navigation (2)

Re: inline newNode()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: inline newNode()
Date: 2002-10-08 15:53:52
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> I don't like making the code GCC-specific any more than anyone else
> does, but given that the code-bloat is specific to the inline version
> of newNode (which in the scheme I described earlier would be
> GCC-only) -- so introducing a GCC-specific fix for a GCC-specific
> problem isn't too bad, IMHO.

> Or we could just use your other suggestion: define a variant of
> MemSet() and use it when we know it's safe. Not sure which is the
> better solution: any comments?

If we're going with a GCC-only approach to inlining newNode then it
seems like a tossup to me too.  Any other thoughts out there?

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2002-10-08 16:01:35
Subject: Re: Where to call SetQuerySnapshot
Previous:From: Tom LaneDate: 2002-10-08 15:51:12
Subject: Re: [GENERAL] Large databases, performance

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-10-08 16:04:35
Subject: Re: inline newNode()
Previous:From: Neil ConwayDate: 2002-10-08 04:58:34
Subject: Re: inline newNode()

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group