Re: POC: converting Lists into arrays

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: jesper(dot)pedersen(at)redhat(dot)com
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: POC: converting Lists into arrays
Date: 2019-07-01 23:27:21
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I spent some time experimenting with the idea mentioned upthread of
adding a macro to support deletion of a foreach loop's current element
(adjusting the loop's state behind the scenes). This turns out to work
really well: it reduces the complexity of fixing existing loops around
element deletions quite a bit. Whereas in existing code you have to not
use foreach() at all, and you have to track both the next list element and
the previous undeleted element, now you can use foreach() and you don't
have to mess with extra variables at all.

A good example appears in the trgm_regexp.c changes below. Typically
we've coded such loops with a handmade expansion of foreach, like

prev = NULL;
cell = list_head(state->enterKeys);
while (cell)
TrgmStateKey *existingKey = (TrgmStateKey *) lfirst(cell);

next = lnext(cell);
if (need to delete)
state->enterKeys = list_delete_cell(state->enterKeys,
cell, prev);
prev = cell;
cell = next;

My previous patch would have had you replace this with a loop using
an integer list-position index. You can still do that if you like,
but it's less change to convert the loop to a foreach(), drop the
prev/next variables, and replace the list_delete_cell call with

foreach(cell, state->enterKeys)
TrgmStateKey *existingKey = (TrgmStateKey *) lfirst(cell);

if (need to delete)
state->enterKeys = foreach_delete_current(state->enterKeys,

So I think this is a win, and attached is v7.

regards, tom lane

Attachment Content-Type Size
reimplement-List-as-array-7.patch.gz application/x-gzip 44.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-07-01 23:32:15 Re: Increasing default value for effective_io_concurrency?
Previous Message Peter Eisentraut 2019-07-01 23:03:53 Re: Are there still non-ELF BSD systems?