Skip site navigation (1) Skip section navigation (2)

Re: Commands/ directory reorganisation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Gray <jgray(at)azuli(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org,Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: Commands/ directory reorganisation
Date: 2002-04-15 00:33:31
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
John Gray <jgray(at)azuli(dot)co(dot)uk> writes:
> Patch attached in line with my previous statement on -hackers about
> reorganisation of files in the commands directory. (Note that define.c
> has been kept, holding some of the common support code for define
> routines.)

This patch looks reasonable to me, with one significant gripe and a
couple of minor ones.

The significant gripe is that I don't think domaincmds.c should exist;
domains are not really different from types and so I think their
commands should be in typecmds.c.  Splitting into two files doesn't do
much except eliminate the possibility of sharing code via "static"

I have one or two trivial coding-style issues too, like not wanting to
see "extern" on routine definitions.

If no one has any other objections, I'll fix the things that are
bothering me and check it in.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-04-15 00:34:50
Subject: Re: Commands/ directory reorganisation
Previous:From: Bruce MomjianDate: 2002-04-15 00:06:05
Subject: Re: BETWEEN Help

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group