Re: POC: converting Lists into arrays

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: jesper(dot)pedersen(at)redhat(dot)com
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: POC: converting Lists into arrays
Date: 2019-07-01 18:44:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> writes:
> This needs a rebase. After that check-world passes w/ and w/o

Yup, here's a rebase against HEAD (and I also find that check-world shows
no problems). This is pretty much of a pain to maintain, since it changes
the API for lnext() which is, um, a bit invasive. I'd like to make a
decision pretty quickly on whether we're going to do this, and either
commit this patch or abandon it.

> There is some unneeded MemoryContext stuff in async.c's
> pg_listening_channels() which should be cleaned up.

Yeah, there's a fair amount of follow-on cleanup that could be undertaken
afterwards, but I've wanted to keep the patch's footprint as small as
possible for the moment. Assuming we pull the trigger, I'd then go look
at removing the planner's duplicative lists+arrays for RTEs and such as
the first cleanup step. But thanks for the pointer to async.c, I'll
check that too.

regards, tom lane

Attachment Content-Type Size
reimplement-List-as-array-6.patch.gz application/x-gzip 44.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ashwin Agrawal 2019-07-01 19:08:06 Re: Zedstore - compressed in-core columnar storage
Previous Message Alvaro Herrera 2019-07-01 18:06:28 Re: [PATCH][PROPOSAL] Add enum releation option type