Re: Use -fvisibility=hidden for shared libraries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Use -fvisibility=hidden for shared libraries
Date: 2022-01-11 00:01:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> [ v2-0001-Use-hidden-visibility-for-shared-libraries-where-.patch ]

This seems like a good idea, but it's failing to apply right now,
mainly because of some cleanup I did in e04a8059a. As far as I can
tell given the now-clarified meanings of PGDLLIMPORT/PGDLLEXPORT,
this patch shouldn't be touching PGDLLIMPORT. The attached revision
works for me under gcc 8.5 and clang 13.

Also, it seemed like you'd maybe been more enthusiastic than necessary
about plastering PGDLLEXPORT on things. I got through check-world
cleanly without the diffs in either ltree.h or worker_spi.c (although
I confess being confused why I didn't need the latter). I didn't try
individually removing other diffs. Those diffs are still in v3 below,
but we should clarify exactly which functions need marking.

regards, tom lane

Attachment Content-Type Size
v3-0001-Use-hidden-visibility-for-shared-libraries-where-.patch text/x-diff 21.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-01-11 00:04:32 Re: sepgsql logging
Previous Message Zhihong Yu 2022-01-10 23:34:27 Re: null iv parameter passed to combo_init()