Skip site navigation (1) Skip section navigation (2)

Re: Ripping out pg_restore's attempts to parse SQL before sending it

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Ripping out pg_restore's attempts to parse SQL before sending it
Date: 2011-07-28 03:28:00
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
I wrote:
> While I've not yet done any excavation in the commit logs to confirm
> this, the nearby comments in the code indicate that separation of COPY
> data from SQL commands was adopted in archive format version 1.3, which
> is ancient.  In fact, it's so ancient that there was never a production
> release of pg_dump that created pre-1.3 archives --- only 7.1devel
> versions ever produced those.

I've now poked around in the commit history, and found that pg_dump's
archive format, as well as pg_restore itself, were introduced in commit
500b62b05 of 2000-07-04.  The 1.3 format revision was added in commit
e8f69be05 of 2000-07-21.  So not only did the prior formats not get
written by any production releases, there was only an interval of a
couple of weeks where they'd even have been emitted by development HEAD.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Pavel StehuleDate: 2011-07-28 04:11:25
Subject: Re: patch for 9.2: enhanced errors
Previous:From: Robert HaasDate: 2011-07-28 02:51:49
Subject: cheaper snapshots

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group