Re: sslinfo extension - add notbefore and notafter timestamps

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sslinfo extension - add notbefore and notafter timestamps
Date: 2024-03-22 13:14:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 20 Mar 2024, at 17:32, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:

> I can't find anything else to note; patch LGTM.

While staging this to commit I realized one silly thing about it warranting
another round here. The ASN.1 timediff code can diff against *any* timestamp,
not just the UNIX epoch, so we could just pass in the postgres epoch and skip
the final subtraction since we're already correctly adjusted. This removes the
non-overflow checked arithmetic with a simpler logic.

Daniel Gustafsson

Attachment Content-Type Size
v12-0001-Add-notBefore-and-notAfter-to-SSL-cert-info-disp.patch application/octet-stream 28.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bernd Helmle 2024-03-22 13:20:50 Re: [PATCH] Add sortsupport for range types and btree_gist
Previous Message Peter Eisentraut 2024-03-22 12:51:14 Re: UUID v7