Re: Deprecation warnings on Rocky 10.2 with current dev branch

I wrote:
> After studying the libxml2 source code I realized that
> xmlParseInNodeContext doesn't automatically attach anything at all to
> the passed-in node or its document; those are used only as context.
> So I think we can clean this up noticeably by attaching the content
> node list to that root node instead of returning it separately.
> Essentially, this is moving the data structure hacking that
> xmltotext_with_options did into xml_parse. Here's a slightly less
> hasty version.

The cfbot pointed out that this patch is drawing warnings since
3ee0edb91 added -Wshadow=local. Here's a less shadow-y version;
no substantive change.

regards, tom lane