Re: BUG #2488: backup history file is archived doubly

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Masao Fujii" <fujii(dot)masao(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #2488: backup history file is archived doubly
Date: 2006-06-22 18:46:56
Message-ID: 2337.1151002016@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"Masao Fujii" <fujii(dot)masao(at)oss(dot)ntt(dot)co(dot)jp> writes:
> The cause of the problem is that pg_stop_backup creates two *.ready files.
> One file is created by pg_stop_backup > RemoveOldBackupHistory >
> XLogArchiveIsDone > XLogArchiveNotify.
> Another is created by pg_stop_backup > XLogArchiveNotify.

Oooh, good catch. The cleanest solution would be to modify
RemoveOldBackupHistory so that it explicitly skips the current entry.
But I'm strongly tempted to just remove the code in pg_stop_backup,
and document that RemoveOldBackupHistory gets the job done (perhaps
renaming it).

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Eresmas 2006-06-22 19:50:26 Re: BUG #2487: Immutable functions results
Previous Message Tom Lane 2006-06-22 17:41:32 Re: BUG #2490: '||' and type casting for user defined types