Skip site navigation (1) Skip section navigation (2)

Re: CVS tip problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: olly(at)lfix(dot)co(dot)uk
Cc: pgsql-hackers(at)postgresql(dot)org,Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: CVS tip problems
Date: 2004-06-01 13:51:11
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Oliver Elphick <olly(at)lfix(dot)co(dot)uk> writes:
> -       strerror_r(errnum, strerrbuf, buflen);
> +       char buf[256];
> +       StrNCpy(strerrbuf, strerror_r(errnum, buf, 256), buflen);
>         return strerrbuf;

Easier and safer would be

> -       strerror_r(errnum, strerrbuf, buflen);
> -       return strerrbuf;
> +       return strerror_r(errnum, strerrbuf, buflen);

The real point here is that we need to code differently depending on
which flavor of strerror_r we have.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Merlin MoncureDate: 2004-06-01 14:39:31
Subject: Re: [pgsql-hackers-win32] select like...not using index
Previous:From: Tom LaneDate: 2004-06-01 13:42:46
Subject: Re: Fast index build vs. PITR

pgsql-patches by date

Next:From: Euler Taveira de OliveiraDate: 2004-06-01 19:12:55
Subject: small fix in FAQ
Previous:From: Harald FuchsDate: 2004-06-01 08:10:38
Subject: Re: pg_dump --comment?

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group