Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Sun, 2010-02-14 at 17:06 +0000, Greg Stark wrote:
>> EINSUFFICIENTEXPLANATION :)
> ...I like that error code.
I think more EINSUFFICIENTCOMMENTS. The patch should also add a comment
to the function, along the lines of "While we have the lock, also update
RecentGlobalXmin, so that we will have as up-to-date a value as possible
for next time". You've also failed to document the meaning or purpose
of the added output parameter.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2010-02-14 17:52:52|
|Subject: Re: CommitFest Status Summary - 2010-02-14 |
|Previous:||From: Simon Riggs||Date: 2010-02-14 17:41:39|
|Subject: Re: Listen / Notify - what to do when the queue is full|