Skip site navigation (1) Skip section navigation (2)

Re: Optimizing GetConflictingVirtualXIDs()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Optimizing GetConflictingVirtualXIDs()
Date: 2010-02-14 17:45:50
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Sun, 2010-02-14 at 17:06 +0000, Greg Stark wrote:

> ...I like that error code.

I think more EINSUFFICIENTCOMMENTS.  The patch should also add a comment
to the function, along the lines of "While we have the lock, also update
RecentGlobalXmin, so that we will have as up-to-date a value as possible
for next time".  You've also failed to document the meaning or purpose
of the added output parameter.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-02-14 17:52:52
Subject: Re: CommitFest Status Summary - 2010-02-14
Previous:From: Simon RiggsDate: 2010-02-14 17:41:39
Subject: Re: Listen / Notify - what to do when the queue is full

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group