Re: [PATCHES] Fix for large file support (nonsegment mode support)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Fix for large file support (nonsegment mode support)
Date: 2008-03-10 23:20:43
Message-ID: 2247.1205191243@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Tom Lane wrote:
>> Applied with minor corrections.

> Why is this not the default when supported?

Fear.

Maybe eventually, but right now I think it's too risky.

One point that I already found out the hard way is that sizeof(off_t) = 8
does not guarantee the availability of largefile support; there can also
be filesystem-level constraints, and perhaps other things we know not of
at this point.

I think this needs to be treated as experimental until it's got a few
more than zero miles under its belt. I wouldn't be too surprised to
find that we have to implement it as a run-time switch instead of
compile-time, in order to not fail miserably when somebody sticks a
tablespace on an archaic filesystem.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-03-11 01:08:47 Re: [PATCHES] Fix for large file support (nonsegment mode support)
Previous Message Peter Eisentraut 2008-03-10 23:11:43 Re: [PATCHES] Fix for large file support (nonsegment mode support)

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-03-11 01:08:47 Re: [PATCHES] Fix for large file support (nonsegment mode support)
Previous Message Peter Eisentraut 2008-03-10 23:11:43 Re: [PATCHES] Fix for large file support (nonsegment mode support)