Skip site navigation (1) Skip section navigation (2)

Re: pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.
Date: 2004-08-21 17:21:15
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> Add ALTER INDEX, particularly for moving tablespaces.

This patch is a perfect example of why unreviewed patches should not
go in during beta.

So far I have noticed the following problems with it:

* Added reference page wasn't linked into the docs build.

* Added a field to struct AlterTableStmt, but did not do the necessary
  housekeeping for extending a Node (eg, copyfuncs and equalfuncs
  adjustments), nor make sure the field is validly set in every place
  an AlterTableStmt is constructed.

* ALTER INDEX RENAME doesn't actually work.

regression=# alter index foo_pkey rename to zzz;
ERROR:  unrecognized rename stmt type: 9

That's not counting the problem someone else already reported with
incorrect tab-completion.

			regards, tom lane

In response to


pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-08-21 18:45:59
Subject: pgsql-server: Fix tab completion for ALTER INDEX.
Previous:From: Tom LaneDate: 2004-08-21 16:16:04
Subject: pgsql-server: Seems it would be nice if the ALTER INDEX ref page were

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group