|From:||Daniel Gustafsson <daniel(at)yesql(dot)se>|
|To:||Michael Paquier <michael(at)paquier(dot)xyz>|
|Cc:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, clemens(at)ladisch(dot)de, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> On 12 Jun 2019, at 04:36, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jun 11, 2019 at 09:32:55AM -0400, Alvaro Herrera wrote:
>> Yeah, looks better. I think the error message should be a normal elog()
>> cache failure, though ... at least in the COMMENT case, the obj-does-not-
>> exist message is supposed to be thrown by get_object_address(), before
>> check_object_ownership is called.
>> As a matter of style, I would get rid of the 'conoid' variable and just
>> use address.objectId where needed.
> OK. I have included both your comments, and committed the patch down
> to 9.5 where it applies. Thanks for the feedback!
> s/unathorized/unauthorized/ by the way.
Ugh, sorry about that.
|Next Message||PG Bug reporting form||2019-06-12 09:51:07||BUG #15847: Running out of memory when planning full outer joins involving many partitions|
|Previous Message||Alvaro Herrera||2019-06-12 04:51:52||Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID|