Add privileges test for pg_stat_statements to improve coverage

From: kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp
To: pgsql-hackers(at)postgresql(dot)org
Subject: Add privileges test for pg_stat_statements to improve coverage
Date: 2024-04-23 06:44:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi hackers,

I proposal adding privileges test to improve
test coverage of pg_stat_statements.

## test procedure

./configure --enable-coverage --enable-tap-tests --with-llvm CFLAGS=-O0
make check-world
make coverage-html

## coverage

before Line Coverage 74.0 %(702/949 lines)
after Line Coverage 74.4 %(706/949 lines)

Although the improvement is small, I think that test regarding
privileges is necessary.

As a side note,
Initially, I was considering adding a test for dealloc.
However, after reading the thread below, I confirmed that
it is difficult to create tests due to differences due to endian.
For this reason, I first added a test about privileges.

Best Regards,

Keisuke Kuroda
NTT Comware

Attachment Content-Type Size
add_privileges_test_for_pg_stat_statements.patch text/x-diff 5.9 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-04-23 07:07:32 Re: Direct SSL connection with ALPN and HBA rules
Previous Message Michael Paquier 2024-04-23 05:49:43 Re: query_id, pg_stat_activity, extended query protocol