Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Formatting patch for psql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Formatting patch for psql
Date: 2005-11-25 14:58:21
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> ... There is a fair
> bit of encoding code in there already but the information you need here
> is specifically: is this char a control character and in particular, is
> it a newline.

The appropriate test for that is just "ch == '\n'", in all the encodings
we support (although you do have to be careful that ch isn't a non-first
byte of a multibyte character).  If that's all you need then inventing
a bunch of additional infrastructure is really inappropriate.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Pavel StehuleDate: 2005-11-25 16:01:35
Subject: is not distinct from
Previous:From: Martijn van OosterhoutDate: 2005-11-25 10:42:26
Subject: Re: [PATCH] Formatting patch for psql

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group