Re: psql: Add role's membership options to the \du+ command

From: Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Add role's membership options to the \du+ command
Date: 2023-02-27 20:14:42
Message-ID: 22110b1f-dac6-d812-1742-7e915b60f893@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22.02.2023 00:34, David G. Johnston wrote:
> This is the format I've gone for (more-or-less) in my RoleGraph view
> (I'll be sharing it publicly in the near future).
>
> bob from grantor (a, s, i) \n
> adam from postgres (a, s, i) \n
> emily from postgres (empty)

I think this is a good compromise.

> Based upon prior comments going for something like the following is
> undesirable: bob=asi/grantor

Agree. Membership options are not the ACL (although they have
similarities). Therefore, showing them as a ACL-like column will be
confusing.

So, please find attached the second version of the patch. It implements
suggested display format and small refactoring of existing code for \du
command.
As a non-native writer, I have doubts about the documentation part.

--
Pavel Luzanov
Postgres Professional:https://postgrespro.com

Attachment Content-Type Size
v2-0001-psql-du-shows-membership-options.patch text/x-patch 10.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-02-27 20:23:56 Re: Move defaults toward ICU in 16?
Previous Message Tom Lane 2023-02-27 19:58:30 Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)