Re:Re: pg_recvlogical: Prevent flushed data from being re-sent after restarting replication

On 28/11/2025 02:15, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> I've made a few minor adjustments to the test patch.
> The updated version is attached.

Hi,
I was reading your code and had a question about the new code you added in the main() function of pg_recvlogical.c:
if (outfd != -1 && strcmp(outfile, "-") != 0)
OutputFsync(feGetCurrentTimestamp());
In the stream loop, the StreamLogicalLog() function already contains similar code:
if (outfd != -1 &&
feTimestampDifferenceExceeds(output_last_fsync, now,
fsync_interval))
{
if (!OutputFsync(now))
goto error;
}

If the outfile becomes unwritable due to external reasons, would the error reporting here be redundant with the error handling in StreamLogicalLog()?

Best regards,
--
Yilin Zhang