| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Date: | 2026-02-12 14:21:21 |
| Message-ID: | 21cc7a48-99d9-4f69-9a3f-2c2de61ac8e5@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 01/07/2025 14:03, Tomas Vondra wrote:
> Thanks! Pushed, with both adjustments (link to kernel thread, adding the
> commit hash).
I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS
into pg_numa_query_pages) made the function unusable in frontend
programs, because CHECK_FOR_INTERRUPTS is server only. It's not used in
frontend programs today, but it was placed in src/port/ with the idea
that it could be.
That's pretty easy to fix by wrapping it in an "#ifndef FRONTEND" block,
per attached.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Make-pg_numa_query_pages-work-in-frontend-programs.patch | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-02-12 15:53:46 | Re: pgsql: Add file_extend_method=posix_fallocate,write_zeros. |
| Previous Message | Peter Eisentraut | 2026-02-12 12:02:12 | Re: pgsql: Add file_extend_method=posix_fallocate,write_zeros. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-02-12 14:29:34 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | Jakub Wartak | 2026-02-12 14:12:50 | Re: Changing shared_buffers without restart |