Re: [COMMITTERS] pgsql: Unicode escapes in E'...' strings Author: Marko Kreen

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Unicode escapes in E'...' strings Author: Marko Kreen
Date: 2009-09-26 16:02:38
Message-ID: 21929.1253980958@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Marko Kreen <markokr(at)gmail(dot)com> writes:
> On 9/26/09, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> That patch results in the following message from flex:
>>
>> psqlscan.l:1039: warning, -s option given but default rule can be
>> matched

> Agh. Well, that just means the <xeu> state must be commented out:

> -%x xeu
> +/* %x xeu */

Ick --- that breaks the whole concept of keeping the two sets of
flex rules in sync. And it's quite unclear why it fixes the problem,
too. At the very least, if you do it that way, it needs a comment
explaining exactly why it's different from the backend.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-09-26 18:24:49 pgsql: Fix RelationCacheInitializePhase2 (Phase3, in HEAD) to cope with
Previous Message Marko Kreen 2009-09-26 13:33:29 Re: [COMMITTERS] pgsql: Unicode escapes in E'...' strings Author: Marko Kreen

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-09-26 16:09:20 Re: syslog_line_prefix
Previous Message Tom Lane 2009-09-26 15:59:07 Re: TODO item: Allow more complex user/database default GUC settings