| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: expanding inheritance in partition bound order |
| Date: | 2017-08-30 02:36:19 |
| Message-ID: | 2124e99f-9528-0f71-4e10-ac7974dd7077@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/08/29 4:26, Robert Haas wrote:
> I think this patch could be further simplified by continuing to use
> the existing function signature for RelationGetPartitionDispatchInfo
> instead of changing it to return a List * rather than an array. I
> don't see any benefit to such a change. The current system is more
> efficient.
OK, restored the array way.
> I keep having the feeling that this is a big patch with a small patch
> struggling to get out. Is it really necessary to change
> RelationGetPartitionDispatchInfo so much or could you just do a really
> minimal surgery to remove the code that sets the stuff we don't need?
> Like this:
Sure, done in the attached updated patch.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Decouple-RelationGetPartitionDispatchInfo-from-execu.patch | text/plain | 23.3 KB |
| 0002-Teach-expand_inherited_rtentry-to-use-partition-boun.patch | text/plain | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-08-30 03:03:34 | Re: expanding inheritance in partition bound order |
| Previous Message | Masahiko Sawada | 2017-08-30 02:32:10 | Re: pgbench: Skipping the creating primary keys after initialization |