| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-11-07 14:03:27 |
| Message-ID: | 20f9e0dc-0638-98df-abfc-92002d688bbd@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 11/7/18 7:26 AM, Jesper Pedersen wrote:
> On 11/6/18 4:04 PM, Thomas Munro wrote:
>> On Wed, Nov 7, 2018 at 4:42 AM Jesper Pedersen
>> Thanks! Pushed. I'll keep an eye on the build farm to see if
>> anything breaks on Cygwin or some other frankenOS.
>>
>
> There is [1] on Andres' skink setup. Looking.
>
Attached is a reproducer.
Adding the memset() command for the page makes valgrind happy.
Thoughts on how to proceed with this ? The report in [1] shows that
there are a number of call sites where the page(s) aren't fully initialized.
[1]
https://www.postgresql.org/message-id/3fe1e38a-fb70-6260-9300-ce67ede21c32%40redhat.com
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| main.c | text/x-csrc | 541 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-11-07 14:11:04 | Re: valgrind on initdb |
| Previous Message | Andrew Dunstan | 2018-11-07 14:01:13 | Fedora 29 vs linux collation tests |