Skip site navigation (1) Skip section navigation (2)

Re: BUG #6692: Potential Bug in equalfuncs.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: msrbugzilla(at)gmail(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6692: Potential Bug in equalfuncs.c
Date: 2012-06-16 16:31:42
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-bugs
msrbugzilla(at)gmail(dot)com writes:
> I observed a code clone in the following files. The function
> "COMPARE_LOCATION_FIELD" is called in some functions and missed in other
> functions. I wonder if this is a bug. Hope it helps.

Well, COMPARE_LOCATION_FIELD() is a no-op anyway, but for
documentation's sake it should be called in the comparison function for
every node type that has a token location field (some do, some don't).
So far as I can see, it is called where it should be.  Did you observe a
place where it is not, and if so where?

			regards, tom lane

In response to

pgsql-bugs by date

Next:From: Tom LaneDate: 2012-06-16 16:34:51
Subject: Re: BUG #6693: Potential Bug in rewriteManip.c
Previous:From: Bruce MomjianDate: 2012-06-16 02:35:04
Subject: Re: pg_upgrade fails with missing FTS resources

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group