| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Олег Самойлов <splarv(at)ya(dot)ru>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: basic_archive lost archive_directory |
| Date: | 2026-02-09 20:09:41 |
| Message-ID: | 20851770667781@4c74d20d-ac3b-4a50-93f1-fbe5aacb8285 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hello!
> In your patch, only the existence check is moved to basic_archive_configured().
> Would it also make sense to move the filename length check there? If so,
> we could potentially remove the check_archive_directory GUC check hook entirely.
Indeed.
I'm not sure, do I need to keep the check_archive_directory declaration for backport branches? I will split the patch into two parts.
regards, Sergei
| Attachment | Content-Type | Size |
|---|---|---|
| 001-bug_basic_archive_lost_archive_directory.patch | text/x-diff | 2.3 KB |
| 002-basic_archive_remove_check_archive_directory.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-02-09 21:48:05 | Re: basic_archive lost archive_directory |
| Previous Message | Greg Sabino Mullane | 2026-02-09 18:34:50 | Re: Incorrect description for "SET" abbreviation in Time Zone Appendix |