| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | meskes(at)postgresql(dot)org (Michael Meskes) |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Removed comparison of unsigned expression < 0. |
| Date: | 2009-05-26 22:51:57 |
| Message-ID: | 20836.1243378317@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
meskes(at)postgresql(dot)org (Michael Meskes) writes:
> Log Message:
> -----------
> Removed comparison of unsigned expression < 0.
I believe that this change is a bad idea and should be reverted:
> fe-exec.c (r1.200 -> r1.201)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-exec.c?r1=1.200&r2=1.201)
This is correct only if enum ExecStatusType is considered unsigned by
the compiler, an assumption that I don't believe is portable. (In
fact, Zdenek was just complaining about something else that seems to
prove Solaris' compiler treats enums as signed always.)
The other two changes seem ok, since they are for size_t variables which
are definitely supposed to be unsigned.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-05-27 01:18:06 | pgsql: Improve documentation about function volatility: mention the |
| Previous Message | Tom Lane | 2009-05-26 17:36:06 | pgsql: Allow the second argument of pg_get_expr() to be just zero when |