| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: broken regress tests on fedora 36 |
| Date: | 2022-06-09 15:25:14 |
| Message-ID: | 2029652.1654788314@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> Shouldn't we reset the locale setting (LC_NUMERIC?) to a known value?
> We clearly already do that for other categories, or it wouldn't say "Time:".
pg_regress.c and Utils.pm force LC_MESSAGES to C, explaining
* Set translation-related settings to English; otherwise psql will
* produce translated messages and produce diffs.
While that seems clearly necessary, I'm inclined to think that we
should not mess with the user's LC_XXX environment more than we
absolutely must. pg_regress only resets the rest of that if you
say --no-locale, an option the TAP infrastructure lacks.
In short, I think the committed fix is better than this proposal.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-06-09 15:36:09 | doc: Clarify Savepoint Behavior |
| Previous Message | Tom Lane | 2022-06-09 13:50:54 |