Re: Adding REPACK [concurrently]

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Adding REPACK [concurrently]
Date: 2026-03-31 15:35:42
Message-ID: 202603311523.iqhng5ljkzpq@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Mar-31, Antonin Houska wrote:

> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > On Fri, Mar 27, 2026 at 10:31 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:

> > BTW, are we intending to commit this patch series for PG19?
>
> Yes, that's the current plan.

Yes -- though as I said upthread, this particular patch in the series is
the one I'm the least sure about. Also, the structure of the patches to
commit is not like the ones posted here or previously. I'll post a
committable one later on; see below for a breakdown. For now, I brought
the addition of options to table AM methods from [1] into this series,
in what I think is pretty much final form (0002); and I added a 0004
patch that's code review for the big patch, which I'll squash for the
next version, and is posted here separately just so that it's easy to
see.

My intention as to patches for final commit is:

- 0001 "Make index_concurrently_create_copy more general" same as here.
- 0002 "give options bitmask to table_delete/table_update" same as here,
with a real commit message.
- 0003 Rename cluster.c/h to repack.c/h (similar to 0006 here); no
essential change in contents.
- 0004 "Add CONCURRENTLY option to REPACK command". Squash of 0003,
0004, 0005 and 0007.
- 0005 "Error out any process that would block at REPACK", same as here.

I'm unsure on whether 0009 would be pushed or not.

[1] https://postgr.es/m/202603171606.kf6pmhscqbqz@alvherre.pgsql

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

Attachment Content-Type Size
v47-0001-Make-index_concurrently_create_copy-more-general.patch text/x-diff 9.4 KB
v47-0002-give-options-bitmask-to-table_delete-table_updat.patch text/x-diff 10.2 KB
v47-0003-Add-CONCURRENTLY-option-to-REPACK-command.patch text/x-diff 176.0 KB
v47-0004-repack-code-cleanups.patch text/x-diff 11.2 KB
v47-0005-Use-BulkInsertState-when-copying-data-to-the-new.patch text/x-diff 6.7 KB
v47-0006-rename-cluster.c-h-to-repack.c-h.patch text/x-diff 9.1 KB
v47-0007-Fix-a-few-problems-in-index-build-progress-repor.patch text/x-diff 7.4 KB
v47-0008-Error-out-any-process-that-would-block-at-REPACK.patch text/x-diff 12.6 KB
v47-0009-Teach-snapshot-builder-to-skip-transactions-runn.patch text/x-diff 18.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-03-31 15:38:26 Re: Add pg_stat_autovacuum_priority
Previous Message Fujii Masao 2026-03-31 15:33:27 Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?