| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2026-03-10 19:24:25 |
| Message-ID: | 202603101915.kitboh3blier@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have just pushed 0001 with some additional changes. Here's a rebase
of the next ones; no changes other than fixing the conflicts.
I'm seeing this warning caused by 0004, which I think is also being
reported in CI
https://cirrus-ci.com/task/6606871575920640
[281/1134] Compiling C object src/backend/postgres_lib.a.p/commands_cluster.c.o
In file included from ../../source/repack/src/include/access/htup_details.h:22,
from ../../source/repack/src/include/access/relscan.h:17,
from ../../source/repack/src/include/access/heapam.h:19,
from ../../source/repack/src/backend/commands/cluster.c:37:
In function ‘VARSIZE_ANY’,
inlined from ‘restore_tuple’ at ../../source/repack/src/backend/commands/cluster.c:3129:18,
inlined from ‘apply_concurrent_changes’ at ../../source/repack/src/backend/commands/cluster.c:2915:9,
inlined from ‘process_concurrent_changes’ at ../../source/repack/src/backend/commands/cluster.c:3386:2:
../../source/repack/src/include/varatt.h:243:51: warning: array subscript ‘varattrib_4b[0]’ is partly outside array bounds of ‘varlena[1]’ [-Warray-bounds=]
243 | ((((const varattrib_4b *) (PTR))->va_4byte.va_header >> 2) & 0x3FFFFFFF)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
../../source/repack/src/include/varatt.h:467:24: note: in expansion of macro ‘VARSIZE_4B’
467 | return VARSIZE_4B(PTR);
| ^~~~~~~~~~
../../source/repack/src/backend/commands/cluster.c: In function ‘process_concurrent_changes’:
../../source/repack/src/backend/commands/cluster.c:3121:33: note: object ‘varhdr’ of size 4
3121 | varlena varhdr;
| ^~~~~~
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v40-0001-Refactor-index_concurrently_create_copy-for-use-.patch | text/x-diff | 8.7 KB |
| v40-0002-Add-CONCURRENTLY-option-to-REPACK-command.patch | text/x-diff | 165.2 KB |
| v40-0003-Serialize-decoded-tuples-without-flattening.patch | text/x-diff | 20.7 KB |
| v40-0004-Use-BulkInsertState-when-copying-data-to-the-new.patch | text/x-diff | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-03-10 19:27:14 | Re: Add missing stats_reset column to pg_stat_database_conflicts view |
| Previous Message | Pavel Stehule | 2026-03-10 19:21:04 | Re: Potential security risk associated with function call |