Re: UBSAN crash in EventTriggerCollectAlterTSConfig (memcpy with NULL src)

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Florin Irion <irionr(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: UBSAN crash in EventTriggerCollectAlterTSConfig (memcpy with NULL src)
Date: 2026-03-03 19:48:45
Message-ID: 202603031947.a5rjz7rgasas@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Mar-03, Florin Irion wrote:

> While working on the pg_get_domain_ddl() patch [1], I installed an
> event trigger on ddl_command_end in test_setup.sql to automatically
> round-trip DDL. This triggered a UBSAN crash on CI [2] that turns out
> to be a pre-existing bug since b488c580aef(?).

Cool, yeah, this is broken. I propose to add the corresponding test in
src/test/modules/test_ddl_deparse though -- that way we don't need
another event trigger. So how about like this?

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"No es bueno caminar con un hombre muerto"

Attachment Content-Type Size
v2-0001-Don-t-malloc-0-in-EventTriggerCollectAlterTSConfi.patch text/x-diff 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2026-03-03 20:07:17 Re: Don't synchronously wait for already-in-progress IO in read stream
Previous Message Melanie Plageman 2026-03-03 19:48:07 Re: Don't synchronously wait for already-in-progress IO in read stream