| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_createsubscriber --dry-run logging concerns |
| Date: | 2025-10-31 18:02:32 |
| Message-ID: | 202510311750.mxiykx3tp4mx@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Oct-09, Peter Smith wrote:
> Please see the v3 patches.
Okay, I have pushed 0002 to 18 and master. I wanted to backpatch to 17
but there are too many conflicts there.
I'm not opposed to 0001 (to master only), but I think the lines of
dashes are a little excessively noisy. Are there other opinions on
that? Note that vacuumlo also has it, with no dashes.
I'll mark the commitfest item for version 19.
While looking this over, I noticed that we define USEC_PER_SEC, but why?
We already have USECS_PER_SEC, so let's use that. And WaitPMResult
seems an overgrown boolean, so how about we remove it? Patch for these
things attached. Thoughts?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive. (7th Commandment for C Programmers)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_ctl-use-USECS_PER_SEC-from-datatype-timestamp.h-i.patch | text/x-diff | 3.1 KB |
| 0002-Remove-WaitPMResult-enum-in-pg_createsubscriber.patch | text/x-diff | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-10-31 18:09:48 | Re: Should HashSetOp go away |
| Previous Message | Peter Geoghegan | 2025-10-31 17:40:40 | Re: Fully documenting the design of nbtree row comparison scan keys |