| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Nathan Bossart <nathan(at)postgresql(dot)org> |
| Subject: | Re: core dumps in auto_prewarm, tests succeed |
| Date: | 2024-01-23 18:26:17 |
| Message-ID: | 20240123182617.GA2376446@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 23, 2024 at 12:22:58PM -0600, Nathan Bossart wrote:
> On Tue, Jan 23, 2024 at 06:33:25PM +0100, Alvaro Herrera wrote:
>> Does this actually detect a problem if you take out the fix? I think
>> what's going to happen is that postmaster is going to crash, then do the
>> recovery cycle, then stop as instructed by the test; so pg_controldata
>> would report that it was correctly shut down.
>
> Yes, the control data shows "in production" without it. The segfault
> happens within the shut-down path, and the test logs indicate that the
> server continues shutting down without doing a recovery cycle:
I see that ->init turns off restart_after_crash, which might be why it's
not doing a recovery cycle.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-01-23 18:58:30 | Re: generate syscache info automatically |
| Previous Message | Bruce Momjian | 2024-01-23 18:25:04 | Re: FEATURE REQUEST: Role vCPU limit/priority |