Re: cleanup patches for dshash

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Andy Fan <zhihuifan1213(at)163(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: cleanup patches for dshash
Date: 2024-01-22 05:07:15
Message-ID: 20240122050715.GA1924394@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Jan 21, 2024 at 09:51:18PM -0600, Nathan Bossart wrote:
> I did notice a cfbot failure [0]. After a quick glance, I'm assuming this
> is caused by the memcpy() in insert_into_bucket(). Even if the string is
> short, it will copy the maximum key size, which is bad. So, 0002 is
> totally broken at the moment, and we'd need to teach insert_into_bucket()
> to strcpy() instead for string keys to fix it. Perhaps we could add a
> field to dshash_parameters for this purpose...

I attempted to fix this in v2 of the patch set.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v2-0001-Use-NULL-instead-of-0-for-arg-parameter-in-dshash.patch text/x-diff 1.7 KB
v2-0002-Add-hash-compare-functions-for-dshash-tables-with.patch text/x-diff 7.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2024-01-22 05:09:28 Re: Make mesage at end-of-recovery less scary.
Previous Message Michael Paquier 2024-01-22 05:06:56 Re: Fix some typos