| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add new for_each macros for iterating over a List that do not require ListCell pointer |
| Date: | 2024-01-04 22:17:21 |
| Message-ID: | 20240104221721.GA1824373@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Committed after some additional light edits. Thanks for the patch!
On Wed, Jan 03, 2024 at 11:36:36PM +0100, Jelte Fennema-Nio wrote:
> On Wed, 3 Jan 2024 at 23:13, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I like Nathan's wording.
>
> To be clear, I don't want to block this patch on the wording of that
> single comment. So, if you feel Nathan's wording was better, I'm fine
> with that too. But let me respond to your arguments anyway:
I decided to keep the v8 wording, if for no other reason than I didn't see
the need for lots of detail about how it compiles. IMHO even the vague
mention of loop unrolling is probably more than is really necessary.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-01-04 22:24:23 | Re: Adding facility for injection points (or probe points?) for more advanced tests |
| Previous Message | Jim Nasby | 2024-01-04 22:08:28 | Re: SET ROLE x NO RESET |