|From:||Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>|
|To:||Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>|
|Cc:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: pgbnech: allow to cancel queries during benchmark|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Wed, 6 Sep 2023 20:13:34 +0900
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> I attached the updated patch v3. The changes since the previous
> patch includes the following;
> I removed the unnecessary condition (&& false) that you
> pointed out in .
> The test was rewritten by using IPC::Run signal() and integrated
> to "001_pgbench_with_server.pl". This test is skipped on Windows
> because SIGINT causes to terminate the test itself as discussed
> in  about query cancellation test in psql.
> I added some comments to describe how query cancellation is
> handled as I explained in .
> Also, I found the previous patch didn't work on Windows so fixed it.
> On non-Windows system, a thread waiting a response of long query can
> be interrupted by SIGINT, but on Windows, threads do not return from
> waiting until queries they are running are cancelled. This is because,
> when the signal is received, the system just creates a new thread to
> execute the callback function specified by setup_cancel_handler, and
> other thread continue to run. Therefore, the queries have to be
> cancelled in the callback function.
>  https://www.postgresql.org/message-id/a58388ac-5411-4760-ea46-71324d8324cb%40mines-paristech.fr
>  https://www.postgresql.org/message-id/20230906004524.2fd6ee049f8a6c6f2690b99c%40sraoss.co.jp
>  https://learn.microsoft.com/en-us/windows/console/handlerroutine
I found that --disable-thread-safety option was removed in 68a4b58eca0329.
So, I removed codes involving ENABLE_THREAD_SAFETY from the patch.
Also, I wrote a commit log draft.
Attached is the updated version, v4.
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
|Next Message||Peter Eisentraut||2023-09-19 08:33:48||Re: [PATCH] Add native windows on arm64 support|
|Previous Message||Pierre Ducroquet||2023-09-19 08:25:09||Re: Improvements in pg_dump/pg_restore toc format and performances|