Re: Add 'worker_type' to pg_stat_subscription

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Maxim Orlov <orlovmg(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add 'worker_type' to pg_stat_subscription
Date: 2023-09-16 20:40:41
Message-ID: 20230916204041.GA2185423@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Sep 16, 2023 at 06:09:48PM +0530, Amit Kapila wrote:
> I think there is a merit in keeping the worker type as 'sync' or
> 'synchronization' because these would be used in future for syncing
> other objects like sequences. One more thing that slightly looks odd
> is the 'leader apply' type of worker, won't this be confusing when
> there is no parallel apply worker in the system? In this regard,
> probably existing documentation could also be improved.

These are good points. I went ahead and adjusted the patch back to using
"apply" for [leader] apply workers and to using "synchronization" for
synchronization workers. I also adjusted a couple of the error messages
that Michael pointed out to say "synchronization worker" instead of "table
synchronization worker" or "tablesync worker".

This still leaves the possibility for confusion with the documentation's
use of "leader apply worker", but I haven't touched that for now.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v8-0001-Add-worker-type-to-pg_stat_subscription.patch text/x-diff 9.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Wienhold 2023-09-16 20:50:13 Re: JSON Path and GIN Questions
Previous Message David E. Wheeler 2023-09-16 20:26:07 Re: JSON Path and GIN Questions