Re: Add 'worker_type' to pg_stat_subscription

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add 'worker_type' to pg_stat_subscription
Date: 2023-09-15 16:35:38
Message-ID: 20230915163538.GA1960964@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 14, 2023 at 03:04:19PM -0700, Nathan Bossart wrote:
> The only reason I didn't apply this already is because IMHO we should
> adjust the worker types and the documentation for the view to be
> consistent. For example, the docs say "leader apply worker" but the view
> just calls them "apply" workers. The docs say "synchronization worker" but
> the view calls them "table synchronization" workers. My first instinct is
> to call apply workers "leader apply" workers in the view, and to call table
> synchronization workers "table synchronization workers" in the docs.

Concretely, like this.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v7-0001-Add-worker-type-to-pg_stat_subscription.patch text/x-diff 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-09-15 17:50:51 Re: Small patch modifying variable name to reflect the logic involved
Previous Message Jonah H. Harris 2023-09-15 16:24:47 Re: Implement a column store for pg?