Re: [PATCH] Add function to_oct

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Kirk Wolak <wolakk(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Eric Radman <ericshane(at)eradman(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add function to_oct
Date: 2023-07-26 03:29:17
Message-ID: 20230726032917.GA3151386@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jul 25, 2023 at 05:16:56PM -0700, Nathan Bossart wrote:
> On Tue, Jul 25, 2023 at 04:24:26PM -0700, Nathan Bossart wrote:
>> I started taking a look at this and ended up adding to_binary() and a
>> bigint version of to_oct() for completeness. While I was at it, I moved
>> the base-conversion logic out to a separate static function that
>> to_binary/oct/hex all use.
> Bleh, this patch seems to fail horribly on 32-bit builds. I'll look into
> it soon.

Here's a new version of the patch with the silly mistakes fixed.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v4-0001-add-to_binary-and-to_oct.patch text/x-diff 8.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-07-26 03:52:20 Re: Support worker_spi to execute the function dynamically.
Previous Message Richard Guo 2023-07-26 03:17:44 Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower