| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pg_upgrade and logical replication |
| Date: | 2023-04-24 07:22:24 |
| Message-ID: | 20230424072224.qd3awkfrjcanw2pa@jrouhaud |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Apr 18, 2023 at 01:40:51AM +0000, Hayato Kuroda (Fujitsu) wrote:
>
> I found a cfbot failure on macOS [1]. According to the log,
> "SELECT count(*) FROM t2" was executed before synchronization was done.
>
> ```
> [09:24:21.018](0.132s) not ok 18 - Table t2 should now have 3 rows on the new subscriber
> ```
>
> With the patch present, wait_for_catchup() is executed after REFRESH, but
> it may not be sufficient because it does not check pg_subscription_rel.
> wait_for_subscription_sync() seems better for the purpose.
Fixed, thanks!
v5 attached with all previously mentioned fixes.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Optionally-preserve-the-full-subscription-s-state.patch | text/plain | 33.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-04-24 07:24:14 | Re: Improving worst-case merge join performance with often-null foreign key |
| Previous Message | Nikita Malakhov | 2023-04-24 07:12:00 | Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns |