| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> | 
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> | 
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
| Subject: | Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands | 
| Date: | 2023-04-22 04:44:51 | 
| Message-ID: | 20230422044451.GA1644603@nathanxps13 | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
I've attached two patches.  0001 adds a parenthesized CLUSTER syntax that
doesn't require a table name.  0002 is your patch with a couple of small
adjustments.
On Fri, Apr 21, 2023 at 07:29:59PM -0400, Melanie Plageman wrote:
> Attached v2 includes changes for CLUSTER syntax docs. I wasn't quite
> sure that we can move down CLUSTER [VERBOSE] syntax to the compatibility
> section since CLUSTER (VERBOSE) doesn't work. This seems like it should
> work (VACUUM and ANALYZE do). I put extra "[ ]" around the main CLUSTER
> syntax but I don't know that this is actually the same as documenting
> that CLUSTER VERBOSE does work but CLUSTER (VERBOSE) doesn't.
I'm not sure about moving CLUSTER [VERBOSE] to the compatibility section,
either.  At the very least, I don't think what I have in 0002 is accurate.
It claims that syntax was used before v14, but it's still the only way to
do a "verbose" CLUSTER without a table name in v15 and v16, too.  Perhaps
we should break it apart, or maybe we can just say it was used before v17.
WDYT?
-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size | 
|---|---|---|
| v3-0001-Support-parenthesized-syntax-for-CLUSTER-without-.patch | text/x-diff | 3.8 KB | 
| v3-0002-Doc-move-unparenthesized-syntax-for-a-few-command.patch | text/x-diff | 7.2 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-04-22 08:39:28 | Re: Fix documentation for max_wal_size and min_wal_size | 
| Previous Message | Imseih (AWS), Sami | 2023-04-22 03:36:15 | Re: Correct the documentation for work_mem |