Re: refactoring relation extension and BufferAlloc(), faster COPY

From: Andres Freund <andres(at)anarazel(dot)de>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: refactoring relation extension and BufferAlloc(), faster COPY
Date: 2023-03-26 19:26:59
Message-ID: 20230326192659.hmmbizchu4zy7kix@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Attached is v5. Lots of comment polishing, a bit of renaming. I extracted the
relation extension related code in hio.c back into its own function.

While reviewing the hio.c code, I did realize that too much stuff is done
while holding the buffer lock. See also the pre-existing issue
https://postgr.es/m/20230325025740.wzvchp2kromw4zqz%40awork3.anarazel.de

Greetings,

Andres Freund

Attachment Content-Type Size
v5-0001-Add-some-error-checking-around-pinning.patch text/x-diff 3.1 KB
v5-0002-hio-Release-extension-lock-before-initializing-pa.patch text/x-diff 2.0 KB
v5-0003-Add-smgrzeroextend-FileZero-FileFallocate.patch text/x-diff 12.1 KB
v5-0004-bufmgr-Add-Pin-UnpinLocalBuffer.patch text/x-diff 6.7 KB
v5-0005-bufmgr-Remove-buffer-write-dirty-tracepoints.patch text/x-diff 3.1 KB
v5-0006-bufmgr-Acquire-and-clean-victim-buffer-separately.patch text/x-diff 27.8 KB
v5-0007-bufmgr-Support-multiple-in-progress-IOs-by-using-.patch text/x-diff 12.4 KB
v5-0008-bufmgr-Move-relation-extension-handling-into-Exte.patch text/x-diff 43.8 KB
v5-0009-Convert-a-few-places-to-ExtendBufferedRel.patch text/x-diff 12.9 KB
v5-0010-heapam-Add-num_pages-to-RelationGetBufferForTuple.patch text/x-diff 6.8 KB
v5-0011-hio-Use-ExtendBufferedRelBy.patch text/x-diff 13.0 KB
v5-0012-WIP-Don-t-initialize-page-in-vm-fsm-_extend-not-n.patch text/x-diff 2.1 KB
v5-0013-Convert-a-few-places-to-ExtendBufferedRelTo.patch text/x-diff 11.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-03-26 19:39:08 Re: meson/msys2 fails with plperl/Strawberry
Previous Message Jeff Davis 2023-03-26 18:00:02 Re: Request for comment on setting binary format output per session