Re: recovery modules

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: recovery modules
Date: 2023-02-02 19:37:00
Message-ID: 20230202193700.GA3887858@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Feb 02, 2023 at 02:34:17PM +0900, Michael Paquier wrote:
> Okay, the changes done here look straight-forward seen from here. I
> got one small-ish comment.
> +basic_archive_startup(ArchiveModuleState *state)
> +{
> + BasicArchiveData *data = palloc0(sizeof(BasicArchiveData));
> Perhaps this should use MemoryContextAlloc() rather than a plain
> palloc(). This should not matter based on the position where the
> startup callback is called, still that may be a pattern worth
> encouraging.

Good call.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v5-0001-s-ArchiveContext-ArchiveCallbacks.patch text/x-diff 2.8 KB
v5-0002-move-archive-module-exports-to-dedicated-headers.patch text/x-diff 6.9 KB
v5-0003-restructure-archive-modules-API.patch text/x-diff 13.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2023-02-02 19:51:45 Re: Amcheck verification of GiST and GIN
Previous Message Pavel Stehule 2023-02-02 18:35:28 Re: Schema variables - new implementation for Postgres 15 (typo)