| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, thomas(dot)munro(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, john(dot)naylor(at)enterprisedb(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, jchampion(at)timescale(dot)com, sawada(dot)mshk(at)gmail(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com |
| Subject: | Re: Improve logging when using Huge Pages |
| Date: | 2023-02-02 15:53:37 |
| Message-ID: | 20230202155337.gwsjcszhxhdgqmhs@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Jan-24, Justin Pryzby wrote:
> On Mon, Jan 23, 2023 at 05:33:35PM -0800, Andres Freund wrote:
> > I'm ok with this being a GUC, it doesn't feel elegant, but I suspect there's
> > no realistic elegant answer.
> Whether it's a GUC or a function, I propose to name it hugepages_active.
> If there's no objections, I'll add to the CF.
Maybe I misread the code (actually I only read the patch), but -- does
it set active=true when huge_pages=on? I think the code only works when
huge_pages=try. That might be pretty confusing; I think it should say
"on" in both cases.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Hay dos momentos en la vida de un hombre en los que no debería
especular: cuando puede permitírselo y cuando no puede" (Mark Twain)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-02-02 16:31:46 | Re: Move defaults toward ICU in 16? |
| Previous Message | Reid Thompson | 2023-02-02 15:41:55 | Re: Add the ability to limit the amount of memory that can be allocated to backends. |