Re: pg_stat_statements and "IN" conditions

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>, Pavel Trukhanov <pavel(dot)trukhanov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_stat_statements and "IN" conditions
Date: 2023-01-29 13:32:19
Message-ID: 20230129133219.tpuzqbyqw3ojztbd@erthalion.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Sun, Jan 29, 2023 at 09:56:02AM -0300, Marcos Pegoraro wrote:
> Em dom., 29 de jan. de 2023 às 09:24, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
> escreveu:
> > > On Fri, Jan 27, 2023 at 08:15:29PM +0530, vignesh C wrote:
> > > The patch does not apply on top of HEAD as in [1], please post a rebased
> > patch:
> >
> > Thanks. I think this one should do the trick.
> >
> There is a typo on DOC part
> + and it's length is larger than <varname> const_merge_threshold
> </varname>,
> + then array elements will contribure nothing to the query
> identifier.
> + Thus the query will get the same identifier no matter how many
> constants
> That "contribure" should be "contribute"

Indeed, thanks for noticing.

Attachment Content-Type Size
v11-0001-Prevent-jumbling-of-every-element-in-ArrayExpr.patch text/x-diff 34.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2023-01-29 13:33:22 Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt().
Previous Message Jim Jones 2023-01-29 13:02:18 Re: Authentication fails for md5 connections if ~/.postgresql/postgresql.{crt and key} exist